Give feedback on rules

Feedback is encouraged on our open GitHub repository, so while you will need a GitHub account, you don't have to be a member of the Community Group to contribute in this way.

If you "watch" the repository, you will get notifications when changes are happening. See more information on GitHub in the page propose rules.

Feedback for ideas and early drafts (Issues on GitHub)

Rule ideas and definitions (shared terms across rules) that are currently GitHub issues can be anything from just a title to an almost finished rule draft. These Issues will be prefixed with either "Rule:" or possibly "New Rule:".

The top comment on such an issue should hold the most up to date version of the rule idea or algorithm, and underneath there will be a thread of related comments and a history of actions.

Please feel free to add your own comments to these issues.

To start giving such feedback:

Feedback and reviews for draft rules (Pull Requests on GitHub)

Pull requests are rule drafts that are ready for peer review. You can add yourself as a reviewer and follow the rule through iterations. A rule needs three approvals, and if a rule has the label "Reviewer wanted", we need more people to review it. However, even if three people are already reviewing it, we can always use more perspectives on things.

You can add single comments to a pull request and/or do a full review.

Only approve a rule if you feel confident (to the best of your knowledge) that this rule is 100% ready to be a published ACT rule. Please also refer to the Definition of "Done".

If you for some reason are not so confident, you can always leave a comment for the things that you have an opinion about, without doing a full review.

To start giving feedback and doing reviews for draft rules:

Feedback/corrections for published rules

We also welcome any feedback and suggestions for changes to already published rules. The published rules should be as precise as possible, limiting the number of potential false positives and false negatives. For this, it is important to draw on as many tool and methodology implementations and expert opinions as possible.

Feedback and corrections for existing rules can target any of the sections of the rule itself (Applicability, Expectations, Accessibility Support, etc.), as well as the test cases, for example to expand the edge case coverage.

You have several options for correcting existing rules: